[dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

[Aaron Conole]

Pavan Nikhilesh Bhagavatula <pbhagavatula at marvell.com> writes:

>>Pavan Nikhilesh Bhagavatula <pbhagavatula at marvell.com> writes:
>>
>>>>> >
>>>>> >Any review?
>>>>> >
>>>>> >Are we missing an update in the unit test to catch this issue?
>>>>> >Thanks.
>>>>>
>>>>> We actually caught it in a unit test
>>>>> >test_reciprocal_division
>>>>
>>>>We had this problem since the very start then.
>>>>
>>>>Both reciprocal_division and reciprocal_division_perf are in the
>>"perf"
>>>>list.
>>>>Can they be promoted to the standard list?
>>>
>>> Both of these tests take >=5 min depending on the platform in use
>>which is why
>>> they are placed in perf tests.
>>
>>Is it possible to write a smaller set of tests that can be put in the
>>standard list?
>>
>
> Currently we have MAX_ITERATIONS  (1ULL << 32) for both the tests
> maybe we can reduce it to 1 << 16 for the normal case?

Sounds good to me.  If you submit a patch, we can look at the run time
from the robot submission as well.

>>>>
>>>>
>>>>--
>>>>David Marchand