[dpdk-dev] [PATCH v14 4/7] drivers/net: update Rx RSS hash offload capabilities

[Pavan Nikhilesh Bhagavatula]

<snip>
>> @@ -1556,6 +1557,9 @@ sfc_rx_check_mode(struct sfc_adapter *sa,
>struct rte_eth_rxmode *rxmode)
>>   		rxmode->offloads |=
>DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;
>>   	}
>>
>> +	if (!(rxmode->offloads & DEV_RX_OFFLOAD_RSS_HASH))
>> +		rxmode->offloads |= DEV_RX_OFFLOAD_RSS_HASH;
>> +
>
>I've tried to highlight on my previous review notes, but it looks like not
>that successful. The right condition should check that offload is really
>supported:
>
>if ((offloads_supported & DEV_RX_OFFLOAD_RSS_HASH) &&
>     (~rxmode->offloads & DEV_RX_OFFLOAD_RSS_HASH))
>           rxmode->offloads |= DEV_RX_OFFLOAD_RSS_HASH;
>

Will modify in the next version.

>Basically similar to DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM above
>(including style of disabled offload check just to have common style).
>
>Thanks.
>

Thanks

>>   	return rc;
>>   }
>>
>
>[snip]