[dpdk-dev] [PATCH] net/mlx5: remove redundant new line char in logs

[David Marchand]

On Wed, Oct 30, 2019 at 10:40 AM Dekel Peled <dekelp at mellanox.com> wrote:
> > -----Original Message-----
> > From: David Marchand <david.marchand at redhat.com>
> > Sent: Wednesday, October 30, 2019 11:03 AM
> > To: Dekel Peled <dekelp at mellanox.com>
> > Cc: Matan Azrad <matan at mellanox.com>; Slava Ovsiienko
> > <viacheslavo at mellanox.com>; Shahaf Shuler <shahafs at mellanox.com>; Ori
> > Kam <orika at mellanox.com>; dev <dev at dpdk.org>
> > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char
> > in logs
> >
> > On Wed, Oct 30, 2019 at 9:45 AM Dekel Peled <dekelp at mellanox.com>
> > wrote:
> > >
> > > DRV_LOG macro is used to print log messages, one per line.
> > > In several locations this macro is used with redundant '\n' character
> > > at the end of the log message, causing blank lines between log lines.
> > >
> > > This patch removes the '\n' character where it is redundant.
> >
> > Missing Fixes: ?
>
> This patch is 'cosmetic', not functional.

Having empty lines as noise when debugging is a pain for my pov.
But this is your driver, so fair enough.


-- 
David Marchand