[dpdk-dev] [PATCH v15 2/7] ethdev: add mbuf RSS update as an offload

[Thomas Monjalon]

29/10/2019 16:37, pbhagavatula at marvell.com:
> --- a/doc/guides/rel_notes/release_19_11.rst
> +++ b/doc/guides/rel_notes/release_19_11.rst
> @@ -239,6 +239,13 @@ New Features
>    *  This scheme will allow PMDs to avoid lookup to internal ptype table on Rx
>       and thereby improve Rx performance if application wishes do so.
>  
> +* **Added Rx offload flag to enable or disable RSS update**
> +
> +  *  Added new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to
> +     enable/disable PMDs write to `rte_mbuf::hash::rss`.
> +  *  PMDs notify the validity of `rte_mbuf::hash:rss` to the application
> +     by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`.

Please move this paragraph in the right order (before net drivers).

> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -1048,6 +1048,7 @@ struct rte_eth_conf {
>  #define DEV_RX_OFFLOAD_KEEP_CRC		0x00010000
>  #define DEV_RX_OFFLOAD_SCTP_CKSUM	0x00020000
>  #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM  0x00040000
> +#define DEV_RX_OFFLOAD_RSS_HASH		0x00080000

OK, it looks simple.

Olivier, are missing something regarding mbuf offload?