[dpdk-dev] net/nfb: check rxmac array size

Jakub Neruda neruda at netcope.com
Wed Apr 1 08:38:01 CEST 2020


From: Martin Spinler <spinler at cesnet.cz>

The driver wrongly assumed the presence of at least one rxmac in every
firmware and accessed to non-existing unit

Signed-off-by: Martin Spinler <spinler at cesnet.cz>
Acked-by: Jakub Neruda <neruda at netcope.com>

diff --git a/drivers/net/nfb/nfb_rxmode.c b/drivers/net/nfb/nfb_rxmode.c
index 3327c8272..2d0b613d2 100644
--- a/drivers/net/nfb/nfb_rxmode.c
+++ b/drivers/net/nfb/nfb_rxmode.c
@@ -54,7 +54,8 @@ nfb_eth_promiscuous_get(struct rte_eth_dev *dev)
 	struct nc_rxmac_status status;
 	status.mac_filter = RXMAC_MAC_FILTER_PROMISCUOUS;

-	nc_rxmac_read_status(internals->rxmac[0], &status);
+	if (internals->max_rxmac > 0)
+		nc_rxmac_read_status(internals->rxmac[0], &status);

 	return (status.mac_filter == RXMAC_MAC_FILTER_PROMISCUOUS);
 }
@@ -102,7 +103,9 @@ nfb_eth_allmulticast_get(struct rte_eth_dev *dev)

 	struct nc_rxmac_status status;
 	status.mac_filter = RXMAC_MAC_FILTER_PROMISCUOUS;
-	nc_rxmac_read_status(internals->rxmac[0], &status);
+
+	if (internals->max_rxmac > 0)
+		nc_rxmac_read_status(internals->rxmac[0], &status);

 	return (status.mac_filter == RXMAC_MAC_FILTER_TABLE_BCAST_MCAST);
 }



More information about the dev mailing list