[dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

[David Marchand]

On Fri, Apr 3, 2020 at 10:06 AM Pavan Nikhilesh Bhagavatula
<pbhagavatula at marvell.com> wrote:
>
> ><david.marchand at redhat.com> wrote:
> >> On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob <jerinjacobk at gmail.com>
> >wrote:
> >> - You can still find traces in meson files.
> >> $ git grep -il allow.experimental.api |grep meson.build$ |grep -vE
> >> '^((app|drivers|lib)/meson.build|examples/)'
> >> app/test/meson.build
> >> drivers/net/e1000/base/meson.build
> >> drivers/net/enic/meson.build
> >> drivers/net/i40e/base/meson.build
> >> drivers/net/i40e/meson.build
> >> drivers/net/ixgbe/base/meson.build
> >> drivers/net/octeontx/base/meson.build
> >> drivers/net/qede/base/meson.build
> >> drivers/net/sfc/base/meson.build
> >> drivers/net/thunderx/base/meson.build
> >> lib/librte_mempool/meson.build
> >
> >Sorry, those drivers passing directly the cflag were special cases.
>
> Yup. Mostly base static libs.

Actually, how about something like this in drivers/meson.build ?
Bruce, do you see something wrong with this ?

on top of Pavan patch:

diff --git a/drivers/meson.build b/drivers/meson.build
index 987e616ae7..4d8f842ab8 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -20,7 +20,7 @@ dpdk_driver_classes = ['common',
 disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),
                ).stdout().split()

-default_cflags = machine_args
+default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']
 if cc.has_argument('-Wno-format-truncation')
        default_cflags += '-Wno-format-truncation'
 endif
@@ -105,7 +105,6 @@ foreach class:dpdk_driver_classes

dpdk_conf.set(config_flag_fmt.format(fmt_name.to_upper()),1)
                        lib_name = driver_name_fmt.format(fmt_name)

-                       cflags += '-DALLOW_EXPERIMENTAL_API'
                        dpdk_extra_ldflags += pkgconfig_extra_libs

                        # generate pmdinfo sources by building a temporary

Since the base drivers make use of "cflags", it works afaics.

>
> >This just leaves lib/librte_mempool/meson.build to clean.
>
> I will clean it up in v3. Along with modifying title and updating doc.
>
> Doc to be updated are coding styles and release notes right?
> Let me know if anything else need to be added to the list.

lgtm, thanks.


-- 
David Marchand