[dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters
Thomas Monjalon
thomas at monjalon.net
Wed Apr 8 19:51:35 CEST 2020
08/04/2020 17:49, Lukasz Wojciechowski:
> Hi guys,
>
> I don't know what is the current status of "legacy" build using
> gnumakes, so I added the new DEBUG flag to config just as it was done in
> other libs like eventdev.
> Many guides still point config files as the one that should be changed
> in order to enable some features, so I thought I should add it there.
>
> If I understand well the official build system now is the one based on
> using meson and ninja, however it hasn't got anything similar to the
> gnamakefiles system, e.g.
> in the meson.build file for libraries all the libraries have build
> variable set to true and there are few ifs that check it, but as it's
> set to true all libraries build always.
> And each library considered there defines RTE_LIBRTE_[LIBRARY_NAME].
> It's kind of weird.
>
> foreach l:libraries
> * build = true**
> * reason = '<unknown reason>' # set if build == false to explain why
> ...
> * if not build*
> dpdk_libs_disabled += name
> set_variable(name.underscorify() + '_disable_reason', reason)
> else
> enabled_libs += name
> *dpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1)*
> ...
>
> Have you think about reusing config files in meson configuration and
> have a single point of configuration? Of course all meson flags can
> overwrite the default config.
This is on purpose.
We are removing most of compile-time options with meson.
I think we can use a global option for debug-specific code.
Bruce, what do you recommend?
More information about the dev
mailing list