[dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Tue Apr 14 10:49:44 CEST 2020


Hi Thomas,

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Sunday, April 12, 2020 5:44 PM
> To: dev at dpdk.org; akhil.goyal at nxp.com
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; O'loingsigh,
> Mairtin <mairtin.oloingsigh at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>; Dybkowski, AdamX
> <adamx.dybkowski at intel.com>; Trahe, Fiona <fiona.trahe at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test
> vectors
> 
> 10/04/2020 17:03, Mairtin o Loingsigh:
> > This patch adds test vectors for AES-256 and sets AESNI-MB as the
> > target PMD
> 
> There is really something wrong in the cryptodev API.
> Why the PMD must be selected in the tests?
> Isn't there some capabilities in cryptodev?
> Whitelisting PMD in the test prevents testing capabilities API.
> 
> It looks the required refactoring is not progressing enough.
> I suggest blocking all crypto-related patches until is is fixed.
> 

You are right, but Mairtin was following the same approach as it was taken previously.
I agree that this approach is not the best one and we are currently working
on a better solution.

Thanks,
Pablo



More information about the dev mailing list