[dpdk-dev] [PATCH v5 4/5] net/tap: fix close a valid fd

wangyunjian wangyunjian at huawei.com
Thu Apr 16 05:04:45 CEST 2020


From: Yunjian Wang <wangyunjian at huawei.com>

The internal structure is freed and set to NULL in the
rte_eth_dev_release_port() and zero is a valid fd. Ultimately
leads to a valid fd was closed by mistake.

Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist")
CC: stable at dpdk.org

Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
---
 drivers/net/tap/rte_eth_tap.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 576055e16..eab1fb771 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2451,10 +2451,6 @@ rte_pmd_tap_remove(struct rte_vdev_device *dev)
 	tap_devices_count--;
 	rte_eth_dev_release_port(eth_dev);
 
-	if (internals->ka_fd != -1) {
-		close(internals->ka_fd);
-		internals->ka_fd = -1;
-	}
 	return 0;
 }
 
-- 
2.19.1




More information about the dev mailing list