[dpdk-dev] [PATCH] drivers/crypto: move logtype variables to source files

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Fri Apr 17 10:22:40 CEST 2020



> -----Original Message-----
> From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
> Sent: Wednesday, April 15, 2020 7:22 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Tomasz Duszynski
> <tdu at semihalf.com>; Michael Shamis <michaelsh at marvell.com>; Liron Himi
> <lironh at marvell.com>; Pattan, Reshma <reshma.pattan at intel.com>; Naga
> Suresh Somarowthu <naga.sureshx.somarowthu at intel.com>; Agalya Babu
> RadhaKrishnan <agalyax.babu.radhakrishnan at intel.com>; Mrozowicz,
> SlawomirX <slawomirx.mrozowicz at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>
> Cc: dev at dpdk.org; Richardson, Bruce <bruce.richardson at intel.com>;
> stable at dpdk.org
> Subject: [PATCH] drivers/crypto: move logtype variables to source files
> 
> The four crypto drivers: kasumi, mvsam, snow3g and zuc define logtype
> variables in their header file. As the header files are included in more than one
> compilation unit, it might cause appearance of multiple instances of the variable
> and a linker error.
> Such situation can occur, when no common section is allowed by the compiler
> settings and tentative definitions are placed in BSS section.
> 
> Fixes: 2cba3814932e ("crypto/kasumi: add dynamic logging")
> Cc: naga.sureshx.somarowthu at intel.com
> Fixes: a05a450f42fd ("crypto/mvsam: add dynamic logging")
> Cc: tdu at semihalf.com
> Fixes: f3af5f9d1325 ("crypto/zuc: add dynamic logging")
> Cc: agalyax.babu.radhakrishnan at intel.com
> Fixes: a3277ad47feb ("cryptodev: remove crypto device driver name")
> Cc: slawomirx.mrozowicz at intel.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>


More information about the dev mailing list