[dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

Maxime Coquelin maxime.coquelin at redhat.com
Fri Apr 17 17:17:59 CEST 2020


Hi Marvin,

On 4/15/20 9:30 AM, Liu, Yong wrote:
>> @@ -2120,7 +2119,7 @@ virtio_dev_configure(struct rte_eth_dev *dev)
>>
>> 	/* if request features changed, reinit the device */
>> 	if (req_features != hw->req_guest_features) {
>> -		ret = virtio_init_device(dev, req_features);
>> +		ret = virtio_negotiate_features(hw, req_features);
> Why do we need to change virtio_init_device to virtio_negotiate_features
> here?


You missed to reply to that question from Xiaolong.

Regards,
Maxime



More information about the dev mailing list