[dpdk-dev] [PATCH] net/bnxt: fix CLANG compilation error

Ferruh Yigit ferruh.yigit at intel.com
Mon Apr 20 14:49:52 CEST 2020


On 4/20/2020 1:23 PM, David Marchand wrote:
> On Mon, Apr 20, 2020 at 2:22 PM Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>> On 4/20/2020 8:14 AM, David Marchand wrote:
>>> On Mon, Apr 20, 2020 at 8:28 AM Ajit Khaparde
>>> <ajit.khaparde at broadcom.com> wrote:
>>>>
>>>> Fix a compilation error seen with CLANG.
>>>> The current code causes a typedef redefinition error because
>>>> 'p__LINE__' is a C11 feature. Fixing it by defining it to something
>>>> which is not already defined in the language.
>>>
>>> Can't you reuse the RTE_BUILD_BUG_ON macro instead of redefining this
>>> in your driver?
>>> If the EAL macro is not enough, I suppose we could improve it.
>>>
>>
>> Will squash it on next-net to fix the build error. +1 to using
>> 'RTE_BUILD_BUG_ON' comment if it possible but it can be done as incremental patch.
> 
> Ack.
> 

Squashed into relevant commit in next-net, thanks.



More information about the dev mailing list