[dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

Thomas Monjalon thomas at monjalon.net
Thu Apr 23 12:48:51 CEST 2020


23/04/2020 11:06, Dmitry Kozlyuk:
> On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote:
> > 23/04/2020 01:51, Ranjit Menon:
> > > On 4/22/2020 12:27 AM, talshn at mellanox.com wrote:  
> > > > From: Tal Shnaiderman <talshn at mellanox.com>
> > > > 
> > > > Move common functions between Unix and Windows to eal_config.c.  
> > > 
> > > Like other files in common, we should call this eal_common_config.c  
> > 
> > I am not sure about the interest of repeating the directory name
> > in the file name in general.
> > Do you see a real benefit?
> 
> It allows using VPATH in Makefile. If filenames are identical in different
> VPATH directories, make can't pick both. Makefiles are being deprecated, but
> they'll be around for some more time.

Makefile will be removed in 20.11




More information about the dev mailing list