[dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.

[Wang, Haiyue]

> -----Original Message-----
> From: banxiaozhen benhaz1024 at gmail.com <banxiaozhen benhaz1024 at gmail.com>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>
> Cc: dev at dpdk.org; banxiaozhen <benhaz1024 at gmail.com>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
> 
> From: banxiaozhen <benhaz1024 at gmail.com>
> 
> Signed-off-by: banxiaozhen <benhaz1024 at gmail.com>

The patch looks good.

The name format should be like "Banxiao Zhen", and the commit message is empty ?

> ---
>  drivers/net/e1000/igb_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
>  	default:
>  		PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
>  							filter_type);
> +		ret = -EINVAL;
>  		break;
>  	}
> 
> --
> 2.24.3 (Apple Git-128)