[dpdk-dev] [PATCH v1 00/12] fix rx packets dropped issue

Guo, Jia jia.guo at intel.com
Fri Dec 11 05:31:28 CET 2020


Hi, steve

What I saw is that you replace of frame size checking to mtu checking, but you still use
"18" as overhead number to configure max_rx_pkt_len?
 
uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;

dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;

> -----Original Message-----
> From: Steve Yang <stevex.yang at intel.com>
> Sent: Wednesday, December 9, 2020 11:16 AM
> To: dev at dpdk.org
> Cc: hemant.agrawal at nxp.com; sachin.saxena at oss.nxp.com; Guo, Jia
> <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>;
> xavier.huwei at huawei.com; humin29 at huawei.com;
> yisen.zhuang at huawei.com; oulijun at huawei.com; Xing, Beilei
> <beilei.xing at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Yang, Qiming
> <qiming.yang at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>; Xu, Rosen
> <rosen.xu at intel.com>; hkalra at marvell.com; jerinj at marvell.com;
> ndabilpuram at marvell.com; kirankumark at marvell.com;
> rmody at marvell.com; shshaikh at marvell.com;
> andrew.rybchenko at oktetlabs.ru; mczekaj at marvell.com; wei.dai at intel.com;
> fengchunsong at huawei.com; lihuisong at huawei.com; Yigit, Ferruh
> <ferruh.yigit at intel.com>; chenhao164 at huawei.com; Zhang, Helin
> <helin.zhang at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; yanglong.wu at intel.com;
> xiaolong.ye at intel.com; Xu, Ting <ting.xu at intel.com>; Li, Xiaoyun
> <xiaoyun.li at intel.com>; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Pei, Andy
> <andy.pei at intel.com>; Wei, Dan <dan.wei at intel.com>; skori at marvell.com;
> vattunuru at marvell.com; sony.chacko at qlogic.com; Richardson, Bruce
> <bruce.richardson at intel.com>; ivan.malov at oktetlabs.ru;
> zyta.szpak at semihalf.com; slawomir.rosek at semihalf.com;
> rad at semihalf.com; Yang, SteveX <stevex.yang at intel.com>
> Subject: [PATCH v1 00/12] fix rx packets dropped issue
> 
> The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition,
> this fix will change the boundary condition with 'RTE_ETHER_MTU'.
> 
> When the MTU(1500) set, the frame type of rx packet will be different if
> used different overhead, it will cause the consistency issue, and the normal
> packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU'
> can avoid this issue.
> 
> Following scopes will be changed:
> - 'rte_ethdev'
> - 'app', e.g.: 'test-pmd';
> - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e;
> 
> Steve Yang (12):
>   net/dpaa2: fix the jumbo frame flag condition for mtu set
>   net/e1000: fix the jumbo frame flag condition for mtu set
>   net/hns3: fix the jumbo frame flag condition for mtu set
>   net/i40e: fix the jumbo frame flag condition
>   net/iavf: fix the jumbo frame flag condition
>   net/ice: fix the jumbo frame flag condition
>   net/ipn3ke: fix the jumbo frame flag condition for mtu set
>   net/octeontx: fix the jumbo frame flag condition for mtu set
>   net/octeontx2: fix the jumbo frame flag condition for mtu
>   net/qede: fix the jumbo frame flag condition for mtu set
>   net/sfc: fix the jumbo frame flag condition for mtu set
>   net/thunderx: fix the jumbo frame flag condition for mtu set
> 
>  drivers/net/dpaa2/dpaa2_ethdev.c        |  2 +-
>  drivers/net/e1000/em_ethdev.c           |  2 +-
>  drivers/net/e1000/igb_ethdev.c          |  2 +-
>  drivers/net/hns3/hns3_ethdev.c          |  2 +-
>  drivers/net/hns3/hns3_ethdev_vf.c       |  2 +-
>  drivers/net/i40e/i40e_ethdev.c          |  2 +-
>  drivers/net/i40e/i40e_ethdev.h          |  1 +
>  drivers/net/i40e/i40e_ethdev_vf.c       | 10 +++++-----
>  drivers/net/i40e/i40e_fdir.c            |  2 +-
>  drivers/net/i40e/i40e_rxtx.c            |  8 ++++----
>  drivers/net/iavf/iavf.h                 |  1 +
>  drivers/net/iavf/iavf_ethdev.c          | 10 +++++-----
>  drivers/net/ice/ice_dcf_ethdev.c        |  8 ++++----
>  drivers/net/ice/ice_ethdev.c            |  2 +-
>  drivers/net/ice/ice_ethdev.h            |  1 +
>  drivers/net/ice/ice_rxtx.c              | 10 +++++-----
>  drivers/net/ipn3ke/ipn3ke_representor.c |  2 +-
> drivers/net/octeontx/octeontx_ethdev.c  |  2 +-
> drivers/net/octeontx2/otx2_ethdev_ops.c |  2 +-
>  drivers/net/qede/qede_ethdev.c          |  2 +-
>  drivers/net/sfc/sfc_ethdev.c            |  2 +-
>  drivers/net/thunderx/nicvf_ethdev.c     |  2 +-
>  22 files changed, 40 insertions(+), 37 deletions(-)
> 
> --
> 2.17.1



More information about the dev mailing list