[dpdk-dev] [PATCH 20/40] net/virtio: make interrupt handling more generic

[Xia, Chenbo]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin at redhat.com>
> Sent: Monday, December 21, 2020 5:14 AM
> To: dev at dpdk.org; Xia, Chenbo <chenbo.xia at intel.com>; olivier.matz at 6wind.com;
> amorenoz at redhat.com; david.marchand at redhat.com
> Cc: Maxime Coquelin <maxime.coquelin at redhat.com>
> Subject: [PATCH 20/40] net/virtio: make interrupt handling more generic
> 
> This patch aims at isolating MSIX notion into PCI
> layer.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> ---
>  drivers/net/virtio/virtio.c             |   6 ++
>  drivers/net/virtio/virtio.h             |  11 +-
>  drivers/net/virtio/virtio_ethdev.c      |   7 +-
>  drivers/net/virtio/virtio_pci.c         | 131 ++++++++++++------------
>  drivers/net/virtio/virtio_pci.h         |  25 ++---
>  drivers/net/virtio/virtio_user_ethdev.c |   4 +-
>  6 files changed, 90 insertions(+), 94 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio.c b/drivers/net/virtio/virtio.c
> index ba3203e68b..7e1e77797f 100644
> --- a/drivers/net/virtio/virtio.c
> +++ b/drivers/net/virtio/virtio.c
> @@ -63,3 +63,9 @@ virtio_get_status(struct virtio_hw *hw)
>  {
>  	return VIRTIO_OPS(hw)->get_status(hw);
>  }

[snip]

> 
>  static uint16_t
> @@ -640,7 +640,7 @@ virtio_user_eth_dev_alloc(struct rte_vdev_device *vdev)
>  	 * MSIX is required to enable LSC (see virtio_init_device).
>  	 * Here just pretend that we support msix.
>  	 */
> -	hw->use_msix = 1;
> +	hw->intr_lsc = 1;

As virtio-user does not have the notion of msi-x, should we also clean up the code
comments? I mean 'MSIX is required ... that we support msix'.

Thanks!
Chenbo

>  	hw->use_vec_rx = 0;
>  	hw->use_vec_tx = 0;
>  	hw->use_inorder_rx = 0;
> --
> 2.29.2