[dpdk-dev] [PATCH v3 4/4] add ABI checks

David Marchand david.marchand at redhat.com
Sat Feb 1 16:29:32 CET 2020


On Thu, Jan 30, 2020 at 11:33 PM Thomas Monjalon <thomas at monjalon.net> wrote:
>
> 30/01/2020 17:00, David Marchand:
> > Enabling them requires a configuration that will trigger the ABI dumps
> > generation as part of the existing devtools/test-build.sh and
> > devtools/test-meson-builds.sh scripts.
> [...]
> > --- a/devtools/test-meson-builds.sh
> > +++ b/devtools/test-meson-builds.sh
> >       if [ -f "$builddir/build.ninja" ] ; then
> > +             # for existing environments, force debugoptimized so that ABI
> > +             # checks can run
> > +             $MESON configure --buildtype=debugoptimized $builddir
>
> This is forcing meson to re-run each time, even if the buildtype is
> already "debugoptimized".
> Please query meson configuration to avoid useless re-run:
>
>         $MESON configure $builddir | awk '$1=="buildtype" {print $2}'
>
>

Good catch, will fix.


-- 
David Marchand



More information about the dev mailing list