[dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY

[Thierry Herbelot]

On 2/6/20 3:27 PM, Bruce Richardson wrote:
> On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote:
>> Hello,
>>
>> When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (on an
>> Intel machine):
>>
>> git clone git://dpdk.org/dpdk
>> cd dpdk
>> make config T=x86_64-native-linux-gcc
>> cd build
>> vi .config
>>    => disable RTE_LIBRTE_IPSEC and RTE_LIBRTE_SECURITY
>> make
>> ...
>> == Build drivers/net/octeontx2
>>    CC otx2_rx.o
>> In file included from .../dpdk/drivers/net/octeontx2/otx2_ethdev_sec.h:10,
>>                   from .../dpdk/drivers/net/octeontx2/otx2_rx.h:11,
>>                   from .../dpdk/drivers/net/octeontx2/otx2_ethdev.h:24,
>>                   from .../dpdk/drivers/net/octeontx2/otx2_rx.c:7:
>> .../dpdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error:
>> rte_security.h: No such file or directory
>>   #include <rte_security.h>
>>            ^~~~~~~~~~~~~~~~
>> compilation terminated.
>>
>> This seems cause by f44e7163775537 ('net/octeontx2: add security session
>> operations').
>>
> Disabling parts of the build, particularly libraries, is always likely to
> cause other build failures. I'm not sure we should, or even need to,
> support the disabling of arbitrary libs in DPDK.

Hello,

On the other hand, there is no reason delivering unused code in a DPDK 
application: an application should be free to select its needed 'modules'.

	Thanks

	Thierry

> 
> /Bruce
>