[dpdk-dev] [PATCH v4 2/7] eal/windows: use lowercase filenames for system headers

Dmitry Kozlyuk dmitry.kozliuk at gmail.com
Thu Feb 27 05:25:32 CET 2020


Mixed case in Windows header names causes errors when cross-compiling
from Linux with case-sensitive filesystem using MinGW, because MinGW
distribution provides all platform SDK headers in lowercase. The change
does not affect Windows native builds on case-insensitive filesystems
(NTFS default).

Reported-by: Narcisa Ana Maria Vasile <Narcisa.Vasile at microsoft.com>
Reported-by: William Tu <u9012063 at gmail.com>
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
---
 lib/librte_eal/windows/eal/include/pthread.h | 2 +-
 lib/librte_eal/windows/eal/include/rte_os.h  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/windows/eal/include/pthread.h b/lib/librte_eal/windows/eal/include/pthread.h
index 4ac24de0a..b9dd18e56 100644
--- a/lib/librte_eal/windows/eal/include/pthread.h
+++ b/lib/librte_eal/windows/eal/include/pthread.h
@@ -14,7 +14,7 @@
 extern "C" {
 #endif
 
-#include <Windows.h>
+#include <windows.h>
 
 #define PTHREAD_BARRIER_SERIAL_THREAD TRUE
 
diff --git a/lib/librte_eal/windows/eal/include/rte_os.h b/lib/librte_eal/windows/eal/include/rte_os.h
index c76be1216..95a19b2d3 100644
--- a/lib/librte_eal/windows/eal/include/rte_os.h
+++ b/lib/librte_eal/windows/eal/include/rte_os.h
@@ -15,8 +15,8 @@
 extern "C" {
 #endif
 
-#include <Windows.h>
-#include <BaseTsd.h>
+#include <windows.h>
+#include <basetsd.h>
 #include <pthread.h>
 #include <stdio.h>
 
-- 
2.25.1



More information about the dev mailing list