[dpdk-dev] [PATCH v4] doc: introduce openwrt how-to guide

Mcnamara, John john.mcnamara at intel.com
Fri Jan 17 14:46:26 CET 2020


Hi,

Overall looks good. Some notes below:

> +
> +.. note::
> +
> +	For compiling the NUMA lib, run libtool --version to ensure the
> +libtool version >= 2.2, otherwise the compilation will fail with errors.


This continuation line isn't indented and raised a build error:

    $ make doc-guides-html                                
    sphinx processing guides-html...
    /work/dpdk_docs/doc/guides/howto/openwrt.rst:80: WARNING: 
    Explicit markup ends without a blank line; unexpected unindent.

Also you should used spaces not tabs for indentation in the docs.

> +If you are using Windows PC, you can use some free and opensource raw
> +disk image writer program such as
> +``Win32 Disk Imager`` and ``Etcher`` to write OpenWrt image
> +(openwrt-x86-64-combined-ext4.img) to a USB flash driver or USB SDcard
> with SDcard or a Sata hard drivre or SSD from your PC.

Typo: drive

I'll send you a few other suggested minor corrections.

John



More information about the dev mailing list