[dpdk-dev] [PATCH] ci: increase unit test timeout

Honnappa Nagarahalli Honnappa.Nagarahalli at arm.com
Thu Jan 30 16:35:37 CET 2020



> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Thursday, January 30, 2020 5:03 AM
> To: Ferruh Yigit <ferruh.yigit at intel.com>; Aaron Conole
> <aconole at redhat.com>; Amit Gupta <agupta3 at marvell.com>
> Cc: dev at dpdk.org; Michael Santana <maicolgabriel at hotmail.com>;
> dev at dpdk.org; Aaron Conole <aconole at redhat.com>;
> david.marchand at redhat.com; yipeng1.wang at intel.com; Honnappa
> Nagarahalli <Honnappa.Nagarahalli at arm.com>
> Subject: Re: [dpdk-dev] [PATCH] ci: increase unit test timeout
> 
> 28/01/2020 21:53, Aaron Conole:
> > Ferruh Yigit <ferruh.yigit at intel.com> writes:
> >
> > > Timeout multiplier was 3, which gives 30 seconds for unit test but
> > > still some unit test was timing out time to time and travis
> > > reporting false positive failures.
> > >
> > > Increasing the multiplier to 10, which makes timeout duration
> > > 100seconds.
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> > > ---
> >
> > It's okay to me.  I thought there was an effort to split out
> > performance part of this test from the functional part, but that seems
> > to not have gone anywhere.
> >
> > Acked-by: Aaron Conole <aconole at redhat.com>
> 
> NACK
> The fix should be to split perf tests out of fast-tests.
> 
> The following patch is splitting hash_readwrite_autotest:
> 	https://patchwork.dpdk.org/patch/58726/
> But we are still waiting for a patch splitting hash_readwrite_lf_autotest.
> Please consider working on unit tests as a HIGH PRIORITY (using uppercase ;).
> We should not have to wait so long to see performance tests removed from
> fast unit tests (while keeping the functional coverage).
Apologies, it slipped from my radar. Will send out a patch soon.

> 
> 



More information about the dev mailing list