[dpdk-dev] [PATCH v3 4/4] add ABI checks

Thomas Monjalon thomas at monjalon.net
Thu Jan 30 23:44:41 CET 2020


30/01/2020 17:00, David Marchand:
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> +refsrcdir=$(mktemp -d -t dpdk-${DPDK_ABI_REF_VERSION:-}.XXX)

Instead of a temporary source directory,
could it be inside $DPDK_ABI_REF_DIR/$DPDK_ABI_REF_VERSION ?
I feel it would more "hackable" for debugging of the process.

[..]
> +	if [ -n "$DPDK_ABI_REF_VERSION" ]; then
> +		DPDK_ABI_REF_DIR=${DPDK_ABI_REF_DIR:-reference}
> +		abirefdir=$DPDK_ABI_REF_DIR/$DPDK_ABI_REF_VERSION/$targetdir
> +		if [ ! -d $abirefdir ]; then
> +			# clone current sources
> +			if [ ! -d $refsrcdir/.git ]; then
> +				git clone --local --no-hardlinks \
> +					--single-branch \
> +					-b $DPDK_ABI_REF_VERSION \
> +					$srcdir $refsrcdir
> +			fi
> +
> +			rm -rf $refsrcdir/build
> +			config $refsrcdir $refsrcdir/build $*
> +			compile $refsrcdir/build $abirefdir
> +			$srcdir/devtools/gen-abi.sh $abirefdir
> +		fi






More information about the dev mailing list