[dpdk-dev] [PATCH v1 10/32] eal/trace: implement debug dump function

[Morten Brørup]

> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of jerinj at marvell.com
> Sent: Wednesday, March 18, 2020 8:02 PM
> 
> From: Jerin Jacob <jerinj at marvell.com>
> 
> Implement rte_trace_metadata_dump() and rte_trace_dump()
> functions. Former one used to dump the CTF metadata file and
> the latter one to dump all the registered events and its status.
> 
> Signed-off-by: Jerin Jacob <jerinj at marvell.com>
> Signed-off-by: Sunil Kumar Kori <skori at marvell.com>
> ---
>  lib/librte_eal/common/eal_common_log.c       |  9 +--
>  lib/librte_eal/common/eal_common_trace.c     | 63 ++++++++++++++++++
>  lib/librte_eal/common/eal_common_trace_ctf.c | 67 ++++++++++++++++++++
>  lib/librte_eal/common/eal_private.h          |  3 +
>  lib/librte_eal/rte_eal_version.map           |  2 +
>  5 files changed, 140 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_log.c
> b/lib/librte_eal/common/eal_common_log.c
> index c0efd5214..d8f7feb32 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -372,8 +372,8 @@ RTE_INIT_PRIO(rte_log_init, LOG)
>  	rte_logs.dynamic_types_len = RTE_LOGTYPE_FIRST_EXT_ID;
>  }
> 
> -static const char *
> -loglevel_to_string(uint32_t level)
> +const char *
> +eal_loglevel_to_string(uint32_t level)

Making this function public, rte_ is probably a better prefix than eal_.

There are some functions missing rte_ prefix in eal_private.h, but there's no need to add more.

-Morten