[dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC

[Chautru, Nicolas]

From: Akhil Goyal <akhil.goyal at nxp.com> 
>> 
>> From: Nic Chautru <nicolas.chautru at intel.com>
>> 
>> Supports for FEC 5G PMD Driver on FPGA card PAC N3000
>> 
>> Signed-off-by: Nic Chautru <nicolas.chautru at intel.com>
>> ---
>
>I cannot review this patch. This patch should be a separate series.
>This should be split into logical parts as a new PMD is submitted for review.
>

I will push this PMD in a new serie and keep existing serie for the rest.
Note that this new PMD has quite a lot of similarity with the fpga_lte_fec PMD, no quite created incrementally from scratch.
Still I can create an after-the-fact split : one patchset with empty PMD for build purpose then a couple of patchsets for the ldpc processing operations and configuration.
Would that be helpful and sufficient?

> I can see that all the MACROS, enums, structures are defined in the .c file which Is not correct. Please move the relevant code in .h files and split the whole patch Along with documentation.

This is following the exact same structure as the existing fpga_lte_fec PMD. Still makes sense to change it as suggested.

Thanks
Nic