[dpdk-dev] [PATCH v2] event/dsw: avoid reusing previously recorded events

Mattias Rönnblom hofors at lysator.liu.se
Mon May 4 11:30:59 CEST 2020


From: Mattias Rönnblom <mattias.ronnblom at ericsson.com>

Avoid reusing recorded events when performing a migration, since this
may make the migration selection logic pick an already-moved flow.

Fixes: f6257b22e767 ("event/dsw: add load balancing")
Cc: stable at dpdk.org

Reported-by: Venky Venkatesh <vvenkatesh at paloaltonetworks.com>
Signed-off-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>
---
V2: rebase

 drivers/event/dsw/dsw_event.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index 832390373..367cf8590 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -821,6 +821,9 @@ dsw_port_consider_emigration(struct dsw_evdev *dsw,
 	if (dsw->num_ports == 1)
 		return;
 
+	if (seen_events_len < DSW_MAX_EVENTS_RECORDED)
+	    return;
+
 	DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering emigration.\n");
 
 	/* Randomize interval to avoid having all threads considering
-- 
2.20.1



More information about the dev mailing list