[dpdk-dev] [PATCH 2/2] net/tap: use netlink extended ack support

[Stephen Hemminger]

On Wed, 6 May 2020 19:41:28 +0100
Ferruh Yigit <ferruh.yigit at intel.com> wrote:

> On 4/27/2020 12:32 PM, Andrzej Ostruszka [C] wrote:
> > On 25/04/2020 01:36, Stephen Hemminger wrote:  
> >> In recent Linux kernels, there is support for extended acknowledgement
> >> to netlink messages. This is quite useful for diagnosing errors
> >> in configuration in the kernel with TAP.
> >>
> >> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> >> ---  
> > [...]  
> >> +#else
> >> +/*
> >> + * External ACK support was added in Linux kernel 4.17
> >> + * on older kernels, just ignore that part of message
> >> + */
> >> +#define tap_nl_dump_ext_ack(nh, err) do { } while();  
> > 
> > Maybe "while(0)" here?
> >   
> 
> +1, will fix while merging.
> 
> I assume since it is in #else leg it has not been tested but #if leg tested well.

Yes, haven't built on distros that are old enough to hit the #else :-(