[dpdk-dev] [PATCH] eal: remove register from function parameter in headers

[Bruce Richardson]

On Mon, May 11, 2020 at 09:56:10AM +0100, Burakov, Anatoly wrote:
> On 09-May-20 12:25 AM, Stephen Hemminger wrote:
> > Compiling a C++ application that includes directly or indirectly
> > rte_common.h will cause a warning:
> > 
> > include/rte_common.h:350:37: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister]
> >   rte_combine32ms1b(register uint32_t x)
> > 
> > C++ pickier than standard C and flags this antique usage.
> > 
> > This is a bugfix please apply to 20.05.
> > The register keyword is an old K&R legacy and should be removed
> > everywhere in DPDK. For now, fix it where it hurts.
> > Checkpatch should also be able to flag use of register keyword.
> > 
> > Fixes: 08f683174e94 ("eal: add functions for previous power of 2 alignment")
> > Cc: pbhagavatula at caviumnetworks.com
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > ---
> 
> I remember similar patches already being submitted, and the community has
> decided that 'register' keyword was worth keeping (although i don't recall
> the reasoning). Has something changed since then?
> 
I'm not sure anything has changed - and I don't see the need for register
keyword myself - but all headers must be includable in C++ code. Therefore
we need to remove register from rte_common.h

Acked-by: Bruce Richardson <bruce.richardson at intel.com>