[dpdk-dev] [PATCH] telemetry: fix build for armv7

Bruce Richardson bruce.richardson at intel.com
Mon May 11 16:23:12 CEST 2020


On Mon, May 11, 2020 at 03:58:47PM +0200, David Marchand wrote:
> On Mon, May 11, 2020 at 3:47 PM Bruce Richardson
> <bruce.richardson at intel.com> wrote:
> >
> > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote:
> > > telemetry can not depend on EAL anymore but it still wants to get arch
> > > headers.
> > > We directly point at the right source directories by using the same logic
> > > than EAL. However the special case of armv7 has been missed.
> > >
> > No objection to the fix, but why is ARMv7 needing special treatment?
> 
> For ARMv7, RTE_ARCH == ARCH_DIR so it is not set in mk/arch/* but a
> default value is still set in EAL makefiles.
> We could hide this in rte.vars.mk so that other components' makefiles
> do not have to care about it but I went with the quicker fix.
> 
Thanks for the explanation.

Acked-by: Bruce Richardson <bruce.richardson at intel.com>


More information about the dev mailing list