[dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers

[Stojaczyk, Dariusz]

> -----Original Message-----
> From: Gaëtan Rivet <grive at u256.net>
> Sent: Wednesday, May 13, 2020 11:04 AM
> To: Stephen Hemminger <stephen at networkplumber.org>
> Cc: Stojaczyk, Dariusz <dariusz.stojaczyk at intel.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers
> 
> [SNIP]
> 
> The original code predates the change from macro in commit c742e8d3110b.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable at dpdk.org
> 
> Thanks for the fix,
> Acked-by: Gaetan Rivet <grive at u256.net>
> 

Yes, I wasn't sure if this is a fix or more of a feature. Well, it *could* be backported, I guess.
D.

> > > ---
> > >  lib/librte_pci/rte_pci.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c
> > > index d1ab6b414d..ad2cdfebb2 100644
> > > --- a/lib/librte_pci/rte_pci.c
> > > +++ b/lib/librte_pci/rte_pci.c
> > > @@ -72,9 +72,9 @@ pci_dbdf_parse(const char *input, struct rte_pci_addr
> > > *dev_addr)
> > >
> > >  	errno = 0;
> > >  	val = strtoul(in, &end, 16);
> > > -	if (errno != 0 || end[0] != ':' || val > UINT16_MAX)
> > > +	if (errno != 0 || end[0] != ':' || val > UINT32_MAX)
> > >  		return -EINVAL;
> > > -	dev_addr->domain = (uint16_t)val;
> > > +	dev_addr->domain = (uint32_t)val;
> > >  	in = end + 1;
> > >  	in = get_u8_pciaddr_field(in, &dev_addr->bus, ':');
> > >  	if (in == NULL)
> > > --
> > > 2.17.1
> >
> >
> > Agree this came up before on Hyper-V as well. It meant fixing libpci.
> >
> > Not sure the cast of val is necessary, other than an attempt to silence some
> > static checker
> > about implicit type conversion causing loss of precision.
> >
> >
> > >
> >
> 
> The cast is useless indeed. Remnants from the original macro.
> For now best to leave it as-is, make another patch to remove those
> casts.
> 
> There are other potential bugs in parsing, -FFFFFFFFFFFF0001 is
> considered valid (-FFFFFFFF00000001 with this patch) as well as an empty
> domain.
> I will send a fix for those.
> 
> --
> Gaëtan