[dpdk-dev] [PATCH] app/eventdev: fix unchecked function return values

[Jerin Jacob]

On Thu, May 14, 2020 at 1:53 AM <pbhagavatula at marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>
> Fix unchecked return values reported by coverity.
>
> Coverity issue: 357755
> Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter")
> Cc: stable at dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> ---
>  app/test-eventdev/test_pipeline_common.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 84c42b33c..f1c227941 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -392,8 +392,12 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt,
>                 if (!(cap & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) {
>                         uint32_t service_id = -1U;
>
> -                       rte_event_eth_tx_adapter_service_id_get(consm,
> -                                       &service_id);
> +                       ret = rte_event_eth_tx_adapter_service_id_get(consm,
> +                                                                  &service_id);
> +                       if (ret != -ESRCH && ret != 0) {
> +                               evt_err("Failed to get Tx adptr service ID\n");

\n is not required as evt_err has it.

Acked-by: Jerin Jacob <jerinj at marvell.com>

Fixed and Applied to dpdk-next-eventdev/master. Thanks.



> +                               return ret;
> +                       }