[dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

Morten Brørup mb at smartsharesystems.com
Tue May 26 11:31:22 CEST 2020


guohongzhi,

You must use your real name in the Signed-off-by line.

The signoff must be a real name and not an alias or nickname. For further details, please refer to: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1


Med venlig hilsen / kind regards
- Morten Brørup

> -----Original Message-----
> From: guohongzhi [mailto:guohongzhi1 at huawei.com]
> Sent: Tuesday, May 26, 2020 11:17 AM
> To: dev at dpdk.org
> Cc: olivier.matz at 6wind.com; Morten Brørup;
> konstantin.ananyev at intel.com; jiayu.hu at intel.com;
> ferruh.yigit at intel.com; nicolas.chautru at intel.com;
> cristian.dumitrescu at intel.com; zhoujingbin at huawei.com;
> chenchanghu at huawei.com; jerry.lilijun at huawei.com;
> haifeng.lin at huawei.com; guohongzhi1 at huawei.com
> Subject: [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
> 
> 0xffff is invalid for IPv4 checksum(RFC1624)
> 
> Fixes: 6006818cfb26 ("net: new checksum functions")
> 
> Reviewed-By: Morten Brørup <mb at smartsharesystems.com>
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>
> 
> Signed-off-by: guohongzhi <guohongzhi1 at huawei.com>
> ---
>  lib/librte_net/rte_ip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
> index 1ceb7b7..ece2e43 100644
> --- a/lib/librte_net/rte_ip.h
> +++ b/lib/librte_net/rte_ip.h
> @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
>  {
>  	uint16_t cksum;
>  	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> -	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
> +	return (uint16_t)~cksum;
>  }
> 
>  /**
> --
> 2.21.0.windows.1
> 
> 



More information about the dev mailing list