[dpdk-dev] [PATCH v14 20/23] event/dlb: add PMD's token pop public interface

[McDaniel, Timothy]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Saturday, October 31, 2020 5:09 PM
> To: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Cc: Ray Kinsella <mdr at ashroe.eu>; Neil Horman <nhorman at tuxdriver.com>;
> dev <dev at dpdk.org>; Carrillo, Erik G <erik.g.carrillo at intel.com>; Eads, Gage
> <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>;
> Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Thomas Monjalon
> <thomas at monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH v14 20/23] event/dlb: add PMD's token pop
> public interface
> 
> On Sat, Oct 31, 2020 at 7:23 PM Timothy McDaniel
> <timothy.mcdaniel at intel.com> wrote:
> >
> > The PMD uses a public interface to allow applications to
> > control the token pop mode. Supported token pop modes are
> > as follows, and they impact core scheduling affinity for
> > ldb ports.
> >
> > AUTO_POP: Pop the CQ tokens immediately after dequeueing.
> > DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) events
> >              are released. Supported on load-balanced ports
> >              only.
> > DEFERRED_POP: Pop the CQ tokens during next dequeue operation.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> > Reviewed-by: Gage Eads <gage.eads at intel.com>
> > ---
> >  doc/api/doxy-api-index.md       |   3 +-
> >  drivers/event/dlb/dlb.c         | 145
> ++++++++++++++++++++++++++++++++++++----
> >  drivers/event/dlb/dlb_priv.h    |   3 +
> >  drivers/event/dlb/meson.build   |   4 +-
> >  drivers/event/dlb/rte_pmd_dlb.c |  38 +++++++++++
> >  drivers/event/dlb/rte_pmd_dlb.h |  77 +++++++++++++++++++++
> >  drivers/event/dlb/version.map   |   6 ++
> >  7 files changed, 262 insertions(+), 14 deletions(-)
> >  create mode 100644 drivers/event/dlb/rte_pmd_dlb.c
> >  create mode 100644 drivers/event/dlb/rte_pmd_dlb.h
> >
> > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> > index a9c12d1..2ff3f74 100644
> > --- a/doc/api/doxy-api-index.md
> > +++ b/doc/api/doxy-api-index.md
> > @@ -51,7 +51,8 @@ The public API headers are grouped by topics:
> >    [dpaa2_mempool]      (@ref rte_dpaa2_mempool.h),
> >    [dpaa2_cmdif]        (@ref rte_pmd_dpaa2_cmdif.h),
> >    [dpaa2_qdma]         (@ref rte_pmd_dpaa2_qdma.h),
> > -  [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
> > +  [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h),
> > +  [dlb]                (@ref rte_pmd_dlb.h),
> 
> No comma at the end of the list.
> 
> Plus, missing the dox-api.conf.in update.
> 
> 
> >
> >  - **memory**:
> >    [memseg]             (@ref rte_memory.h),
> 
> 
> > diff --git a/drivers/event/dlb/meson.build b/drivers/event/dlb/meson.build
> > index 552ff9d..7f38c30 100644
> > --- a/drivers/event/dlb/meson.build
> > +++ b/drivers/event/dlb/meson.build
> > @@ -12,7 +12,9 @@ sources = files('dlb.c',
> >                 'dlb_xstats.c',
> >                 'pf/dlb_main.c',
> >                 'pf/dlb_pf.c',
> > -               'pf/base/dlb_resource.c'
> > +               'pf/base/dlb_resource.c',
> > +               'rte_pmd_dlb.c',
> >  )
> >
> >  deps += ['mbuf', 'mempool', 'ring', 'pci', 'bus_pci']
> > +install_headers('rte_pmd_dlb.h')
> 
> We introduced the headers variable, please use it and do not call
> install_headers directly.
> 
> 
> --
> David Marchand


Addressed in next patch-set