[dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

[Bruce Richardson]

Coverity flags a possible problem where the 8-bit wq_idx value may have
errors when shifted and sign-extended to 64-bits. Since this can only occur
if the shift index is larger than any expected value from hardware, it's
unlikely to cause any real problems, but we can eliminate any
possible errors, and the coverity issue, by explicitly typecasting
the uint8_t value to 64-bits before any shift operations occur.

Coverity issue: 363695
Fixes: a33969462135 ("raw/ioat: fix work-queue config size")

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
---
 drivers/raw/ioat/idxd_pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/ioat/idxd_pci.c b/drivers/raw/ioat/idxd_pci.c
index 99ecfbbb4..7bc125014 100644
--- a/drivers/raw/ioat/idxd_pci.c
+++ b/drivers/raw/ioat/idxd_pci.c
@@ -47,7 +47,8 @@ idxd_pci_dev_command(struct idxd_rawdev *idxd, enum rte_idxd_cmds command)
 static uint32_t *
 idxd_get_wq_cfg(struct idxd_pci_common *pci, uint8_t wq_idx)
 {
-	return RTE_PTR_ADD(pci->wq_regs_base, wq_idx << (5 + pci->wq_cfg_sz));
+	return RTE_PTR_ADD(pci->wq_regs_base,
+			(uint64_t)wq_idx << (5 + pci->wq_cfg_sz));
 }
 
 static int
-- 
2.25.1