[dpdk-dev] [PATCH 3/8] ionic: update ionic_if.h to the latest version

Ferruh Yigit ferruh.yigit at intel.com
Tue Nov 3 16:55:40 CET 2020


On 11/3/2020 2:36 PM, Andrew Boyer wrote:
> 
> 
>> On Nov 3, 2020, at 7:44 AM, Ferruh Yigit <ferruh.yigit at intel.com 
>> <mailto:ferruh.yigit at intel.com>> wrote:
>>
>> On 11/2/2020 6:35 PM, Andrew Boyer wrote:
>>> This file contains the firmware interface definitions.
>>
>> Is the version number stored somewhere for documentation?
>>
> 
> No, it is controlled by our internal repository.
> 

It can help you to have one somewhere in the repo (.h, text file, at worst in 
commit log).

>>> Signed-off-by: Andrew Boyer<aboyer at pensando.io <mailto:aboyer at pensando.io>>
>>> ---
>>>  drivers/net/ionic/ionic_if.h   | 1349 ++++++++++++++++++++++----------
>>>  drivers/net/ionic/ionic_regs.h |    3 -
>>>  2 files changed, 933 insertions(+), 419 deletions(-)
>>> diff --git a/drivers/net/ionic/ionic_if.h b/drivers/net/ionic/ionic_if.h
>>> index f83c8711b..fe6b52b17 100644
>>> --- a/drivers/net/ionic/ionic_if.h
>>> +++ b/drivers/net/ionic/ionic_if.h
>>> @@ -1,17 +1,15 @@
>>> -/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB OR BSD-3-Clause */
>>> -/* Copyright (c) 2017-2019 Pensando Systems, Inc.  All rights reserved. */
>>> +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB OR BSD-2-Clause */
>>> +/* Copyright (c) 2017-2020 Pensando Systems, Inc.  All rights reserved. */
>>
>> This is changing the license, for any specific reason?
> 
> Good catch... I am surprised to see the internal and external version of this 
> file have different licenses. (Well, technically different.) I’ll revert that part.
> 
> -Andrew
> 



More information about the dev mailing list