[dpdk-dev] [PATCH v2] eal/windows: fix deadlock when setting alarm

Thomas Monjalon thomas at monjalon.net
Tue Nov 3 21:32:20 CET 2020


30/10/2020 20:25, Kadam, Pallavi:
> On 10/30/2020 11:42 AM, Dmitry Kozlyuk wrote:
> > Windows alarms are both armed and executed from the interrupt thread.
> > rte_eal_alarm_set() dispatched alarm-arming code to that thread and
> > waited for its completion via a spinlock. However, if called from alarm
> > callback (i.e. from the interrupt thread), this caused a deadlock,
> > because arming could not be run until its dispatcher exits, but it could
> > only exit after it finished waiting for arming to complete.
> >
> > Call arming code directly when running in the interrupt thread.
> >
> > Fixes: f4cbdbc7fbd2 ("eal/windows: implement alarm API")
> >
> > Reported-by: Pallavi Kadam <pallavi.kadam at intel.com>
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> > ---
> 
> Tested-by: Pallavi Kadam <pallavi.kadam at intel.com>
> 
> Acked-by: Pallavi Kadam <pallavi.kadam at intel.com>

Applied, thanks




More information about the dev mailing list