[dpdk-dev] [PATCH 1/3] vhost: fix error path when setting memory tables

[Maxime Coquelin]

On 11/6/20 3:53 AM, Xia, Chenbo wrote:
> Hi Maxime,
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin at redhat.com>
>> Sent: Thursday, November 5, 2020 7:46 PM
>> To: dev at dpdk.org; Ding, Xuan <xuan.ding at intel.com>;
>> stephen at networkplumber.org; Yigit, Ferruh <ferruh.yigit at intel.com>;
>> thomas at monjalon.net; Xia, Chenbo <chenbo.xia at intel.com>
>> Cc: stable at dpdk.org; Maxime Coquelin <maxime.coquelin at redhat.com>
>> Subject: [PATCH 1/3] vhost: fix error path when setting memory tables
>>
>> If the an error is encountered before the memory regions
> 'the' should be deleted.
> 
>> are parsed, the file descriptors for these shared buffers
>> is leaked.
> s/is/are/
> 
>> This patch fixes this by closing the message file descriptors
>> on error, taking care of avoiding double closing of the file
>> descriptors. guest_pages is also freed, even though it was not
>> leaked as its pointer was not overiden on subsequent function
> s/overiden/overridden
> 
> With above changes:
> 
> Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
> 

I agree with all above comments.
Will fix in v2.

Thanks,
Maxime