[dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct

[Ferruh Yigit]

On 11/3/2020 2:27 PM, Ferruh Yigit wrote:
> On 11/3/2020 1:20 PM, Xiaoyu Min wrote:
>> From: Xiaoyu Min <jackmin at nvidia.com>
>>
>> The rte_flow_item_eth and rte_flow_item_vlan items are refined [1].
>> The structs do not exactly represent the packet bits captured on the wire
>> anymore so set raw_encap/decap commands should only copy real header
>> instead of the whole struct.
>>
>> Replace the rte_flow_item_* with the existing corresponding rte_*_hdr.
>>
>> [1]:
>> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN
>> items")
>>
>> Signed-off-by: Xiaoyu Min <jackmin at nvidia.com>
> 
> 
> Hi Dekel, Ori,
> 
> This is second fix [1] we get related to the "rte_flow_item_xxx" size changes 
> [2] from you.
> 
> The assumption that 'rte_flow_item_xxx' size is same as xxx header size seems 
> implemented in multiple locations, and changing 'rte_flow_item_xxx' struct size 
> breaking those usage.
> 
> Can one of you guys spend some time to actively check all possible breakages?
> They may be very hard to find unless someone explicitly check for this.
> 

Hi Dekel, Ori,

Is there anyone actively checking for this?


> Thanks,
> ferruh
> 
> 
> [1]
> first one: https://patches.dpdk.org/patch/82863/
> 
> 
> [2]
> Fixes: ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item")
> Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")