[dpdk-dev] [PATCH] net/txgbe: remove direct use of compiler attribute

[Jiawen Wu]

On Tuesday, November 10, 2020 3:19 AM, Ferruh Yigit wrote:
> On 11/9/2020 7:43 AM, Jiawen Wu wrote:
> > Remove direct use of compiler attribute.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
> > ---
> >   drivers/net/txgbe/base/txgbe_dummy.h | 2 +-
> >   drivers/net/txgbe/base/txgbe_osdep.h | 6 ++----
> >   2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/txgbe/base/txgbe_dummy.h
> > b/drivers/net/txgbe/base/txgbe_dummy.h
> > index 0a3a76d0c..3a667dd31 100644
> > --- a/drivers/net/txgbe/base/txgbe_dummy.h
> > +++ b/drivers/net/txgbe/base/txgbe_dummy.h
> > @@ -7,7 +7,7 @@
> >
> >   #ifdef TUP
> >   #elif defined(__GNUC__)
> > -#define TUP(x) x##_unused __attribute__((unused))
> > +#define TUP(x) (x##_unused txgbe_unused)
> 
> Because of build error, removing parenthesis while applying, please double
> check ci build results of the patches [1] and send new version if required.
> Were there any specific reason for the parenthesis, am I missing something
> there?
> 

The parentheses are because of the checkpatch error [1].
But I forgot to build the project again when parentheses added.

[1]
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses

> [1]
> http://mails.dpdk.org/archives/test-report/2020-November/165922.html
> 
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com> Applied to
> dpdk-next-net/main, thanks.