[dpdk-dev] [PATCH v15 00/23] Add DLB PMD

McDaniel, Timothy timothy.mcdaniel at intel.com
Wed Nov 11 21:29:58 CET 2020



> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Tuesday, November 10, 2020 9:51 AM
> To: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Cc: dev <dev at dpdk.org>; Carrillo, Erik G <erik.g.carrillo at intel.com>; Eads,
> Gage <gage.eads at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; Thomas Monjalon <thomas at monjalon.net>; Gaetan
> Rivet <grive at u256.net>
> Subject: Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD
> 
> On Tue, Nov 10, 2020 at 4:29 PM McDaniel, Timothy
> <timothy.mcdaniel at intel.com> wrote:
> >
> > I'm not seeing where we can use librte_pci here.  We are already using the
> dpdk low level rte_pci_read_config(..) APIs.
> > Am I missing something?
> 
> dlb_pci_find_ext_capability is a copy of rte_pci_find_ext_capability
> from the pci bus.
> 
> A lot of DLB_PCI_* defines have a librte_pci equivalent.
> Plus, if there are generic pci defines needed by DLB, they would
> rather belong to librte_pci than a driver.
> 
> 
> --
> David Marchand

David,

I just uploaded patches that should address most of your concerns.
See https://patches.dpdk.org/patch/84034/ and https://patches.dpdk.org/patch/84031/ 

Thanks,
Tim




More information about the dev mailing list