[dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples

Bruce Richardson bruce.richardson at intel.com
Thu Nov 12 10:24:52 CET 2020


On Thu, Nov 12, 2020 at 10:14:23AM +0100, David Marchand wrote:
> On Wed, Nov 11, 2020 at 6:33 PM Bruce Richardson
> <bruce.richardson at intel.com> wrote:
> >
> > On Wed, Nov 11, 2020 at 03:56:47PM +0000, Bruce Richardson wrote:
> > > Rather than just installing all examples, we can use the build checks to
> > > filter out any examples that are missing dependencies or are otherwise
> > > unbuildable on the current system.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > > ---
> > >  examples/meson.build | 54 +++++++++++++++++++++++++++-----------------
> > >  meson.build          |  2 ++
> > >  2 files changed, 35 insertions(+), 21 deletions(-)
> > >
> > This seems to have broken the windows builds because we now process all the
> > examples meson.build file, even if not asked to build them. l2fwd-keepalive
> > has a mandatory, unconditional dependency on librt, which needs to be made
> > optional.
> >
> > Based on that, V3 pending...
> 
> Strange, the v3 patches 2 and 3 linked to the v2 series.
> As far as I can see, the lab only tested the v3 series with patches
> 84029 and 30, so the error on Windows is still reported.
> 
> -- 
> David Marchand
> 
Yes, I see that in patchwork, and it's a bit strange. The emails seem
correctly threaded to me in my mail client though.

I'll resubmit as v4 with a cover letter to see if that allows the CI to run
properly.

/Bruce


More information about the dev mailing list