[dpdk-dev] [PATCH v4 0/4] improve examples installation

Bruce Richardson bruce.richardson at intel.com
Thu Nov 12 12:38:27 CET 2020


On Thu, Nov 12, 2020 at 12:14:27PM +0100, David Marchand wrote:
> On Thu, Nov 12, 2020 at 10:42 AM Bruce Richardson
> <bruce.richardson at intel.com> wrote:
> >
> > This patch improves the installation of the examples when "ninja install" is
> > run. It removes issues with the directory structure being flattened out, and
> > removes from the install list any examples that are not buildable with built
> > DPDK code.
> >
> > V4: resubmit v3 to retest in CI hopefully with proper patch tracking
> >
> > V3: fix issues with building on Windows
> >
> > V2: add support for filtering examples that won't build
> >
> > Bruce Richardson (4):
> >   examples: fix flattening directory layout on install
> >   examples/l2fwd-keepalive: skip build when no librt
> >   examples: stop processing build file if build is impossible
> >   examples: skip installing unbuildable examples
> 
> Thanks Bruce.
> This series looks good to me.
> 
> My only comment is about vm_power_manager which won't build without
> the internal librte_power header.
> It builds fine with meson, because I guess meson pulls this library
> directory into the include flags of the example, but it won't build
> outside.
> 
> We can skip it in devtools/test-meson-builds.sh but, on the other
> hand, I would exclude it from installing until it is fixed (in a
> future release).
> 
Yes, good point.
Rather than adding special logic for it, I think we just add it in the
initialization of the exclusion array in patch 4, i.e.

-dpdk_examples_exclude = []$
+dpdk_examples_exclude = ['vm_power_manager']

Can this be done on apply, or do you want a v5 for it?

/Bruce


More information about the dev mailing list