[dpdk-dev] [kmods PATCH v2] windows: normalize line-endings

Thomas Monjalon thomas at monjalon.net
Fri Nov 13 00:17:45 CET 2020


12/11/2020 21:15, luca.boccassi at gmail.com:
> From: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> 
> MSBuild XML files have to use CRLF line-endings, otherwise any change
> results in the whole file being rewritten with CRLF line-endings by
> Visual Studio. However, it's inconvenient to have such files checked-out
> with CLRF in Unix environments.
> 
> Add suggested git configuration to top-level README, so that Unix
> developers don't miss it. Remove .gitattributes, because core.autocrlf
> overrides eol= attribute. Convert line-endings of the existing files in
> the repository.
> 
> Suggested-by: John Alexander <John.Alexander at datapath.co.uk>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> Signed-off-by: Luca Boccassi <luca.boccassi at microsoft.com>
> ---
> v2 from Luca: run dos2unix on all files in windows/virt2phys folder

[...]
> +Some Windows files use have to use CRLF line-endings.
> +Unix developers can configure git to get only LF on checkout:
> +
> +    git config core.autocrlf input

This is the same as in v1:
	- same typo "use have to use"
	- this config is probably useless





More information about the dev mailing list