[dpdk-dev] [PATCH] mempool: fix ignore return value Coverity issue

Thomas Monjalon thomas at monjalon.net
Fri Nov 13 15:29:02 CET 2020


05/11/2020 14:58, Olivier Matz:
> On Thu, Nov 05, 2020 at 01:51:14PM +0000, David Hunt wrote:
> > Coverity flags that rte_mempool_ops_dequeue_bulk() is called without
> > checking the return value.
> > 
> > This ignoring is intentional, so this patch gets the return code, then
> > uses RTE_SET_USED so that Coverity will be happy.
> > 
> > Coverity issue: 363744
> > Fixes: 449c49b93a6b ("mempool: support handler operations")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: David Hunt <david.hunt at intel.com>
> 
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>
> 
> Thanks David!

This patch is doing nothing else than shutting up Coverity.
Is there any value adding this comment in the code?
Would it be cleaner to mark it as false positive in Coverity itself?




More information about the dev mailing list