[dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

Thomas Monjalon thomas at monjalon.net
Sat Nov 14 14:16:10 CET 2020


13/11/2020 15:31, Juraj Linkeš:
> Add an option to automatically discover the host's numa and cpu counts
> and use those values for a non cross-build.
> Give users the option to override the per-arch default values or values
> from cross files by specifying them on the command line with -Dmax_lcores
> and -Dmax_numa_nodes.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes at pantheon.tech>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
[...]
>  create mode 100644 buildtools/get_cpu_count.py
>  create mode 100644 buildtools/get_numa_count.py

These new files should be added in the file MAINTAINERS.
The recommended pattern is to use - as word separator in script filenames.

I'm also worried there is no more review on such general change,
especially the description in meson_options.txt:

> +option('max_lcores', type: 'integer', value: 0,
> +       description: 'maximum number of cores/threads supported by EAL. Set to positive integer to overwrite per-arch or cross-compilation defaults. Set to -1 to detect the number of cores on the build machine.')
> +option('max_numa_nodes', type: 'integer', value: 0,
> +       description: 'maximum number of NUMA nodes supported by EAL. Set to positive integer to overwrite per-arch or cross-compilation defaults. Set to -1 to detect the number of numa 

I didn't think this series is changing options for all archs.
It was supposed to be an Arm-only rework.
Clearly it is too late for such change in 20.11.


More information about the dev mailing list