[dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference

Timothy McDaniel timothy.mcdaniel at intel.com
Mon Nov 16 18:40:38 CET 2020


Add NULL check before using t->mbuf_pool.

Coverity issue: 363719
Fixes: 83326 ("event/dlb: add PMD self-tests")

Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
---
 drivers/event/dlb/dlb_selftest.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/event/dlb/dlb_selftest.c b/drivers/event/dlb/dlb_selftest.c
index b9ef778c1..8ab00ba87 100644
--- a/drivers/event/dlb/dlb_selftest.c
+++ b/drivers/event/dlb/dlb_selftest.c
@@ -202,7 +202,12 @@ test_stop_flush(struct test *t) /* test to check we can properly flush events */
 		goto err;
 	}
 
-	count = rte_mempool_avail_count(t->mbuf_pool);
+	if (t->mbuf_pool)
+		count = rte_mempool_avail_count(t->mbuf_pool);
+	else {
+		printf("%d: mbuf_pool is NULL\n", __LINE__);
+		goto err;
+	}
 
 	if (rte_event_port_attr_get(evdev,
 				    0,
-- 
2.23.0



More information about the dev mailing list