[dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

Dmitry Kozlyuk dmitry.kozliuk at gmail.com
Sat Nov 21 23:02:21 CET 2020


On Fri, 20 Nov 2020 21:12:55 +0000, Nick Connolly wrote:
> Linking with the 'pci' driver when building with MinGW on
> Windows fails with undefined symbol 'GUID_DEVCLASS_NET'.
> This occurs because devguid.h is included in rte_windows.h
> before INITGUID is defined.
> 
> Resolved by moving the include of devguid.h after the definition
> of INITGUID.

Commit changes should be described in present tense.

> 
> Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers")
> Cc: talshn at mellanox.com

A blank line should be here.

> Signed-off-by: Nick Connolly <nick.connolly at mayadata.io>
> ---

Apart from those nits,
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>


More information about the dev mailing list