[dpdk-dev] [PATCH v2] eal/windows: vfprintf build warning with clang

Nick Connolly nick.connolly at mayadata.io
Sun Nov 29 14:00:47 CET 2020


When building with clang (11.0,--buildtype=debug), eal_lcore.c
produces a -Wformat-nonliteral warning from the vfprintf call
in log_early.

Add __rte_format_printf annotation.

Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA node detection")
Cc: stable at dpdk.org

Signed-off-by: Nick Connolly <nick.connolly at mayadata.io>
Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
---
v2:
* Use __rte_format_printf instead of disabling the warning

 lib/librte_eal/windows/eal_lcore.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c
index d5ff721e0..a85149be9 100644
--- a/lib/librte_eal/windows/eal_lcore.c
+++ b/lib/librte_eal/windows/eal_lcore.c
@@ -38,6 +38,7 @@ static struct cpu_map cpu_map = { 0 };
 
 /* eal_create_cpu_map() is called before logging is initialized */
 static void
+__rte_format_printf(1, 2)
 log_early(const char *format, ...)
 {
 	va_list va;
-- 
2.25.1



More information about the dev mailing list