[dpdk-dev] [PATCH 1/1] eal: increase TRACE CTF SIZE to recommended size

[David Marchand]

On Mon, Oct 5, 2020 at 10:16 PM Timothy McDaniel
<timothy.mcdaniel at intel.com> wrote:
>
> Increase TRACE_CTF_FIELD_SIZE to 448, the recommended size.

Repeating the same sentence in the title and the commitlog does not
give much info.

Plus, what is this "recommendation"?


> Fixes "CTF field is too long" error when running with trace enabled.

Ok, you hit this limit, but it would help to get some context here.
Looking at this patch in the future, we won't know why it was necessary.


>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> ---
>  lib/librte_eal/common/eal_trace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_trace.h b/lib/librte_eal/common/eal_trace.h
> index 92c5951..438c2b7 100644
> --- a/lib/librte_eal/common/eal_trace.h
> +++ b/lib/librte_eal/common/eal_trace.h
> @@ -24,7 +24,7 @@
>
>  #define TRACE_PREFIX_LEN 12
>  #define TRACE_DIR_STR_LEN (sizeof("YYYY-mm-dd-AM-HH-MM-SS") + TRACE_PREFIX_LEN)
> -#define TRACE_CTF_FIELD_SIZE 384
> +#define TRACE_CTF_FIELD_SIZE 448
>  #define TRACE_POINT_NAME_SIZE 64
>  #define TRACE_CTF_MAGIC 0xC1FC1FC1
>  #define TRACE_MAX_ARGS 32
> --
> 2.6.4
>


-- 
David Marchand