[dpdk-dev] [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Tue Oct 6 13:08:41 CEST 2020


Hi David,


> -----Original Message-----
> From: Coyle, David <david.coyle at intel.com>
> Sent: Tuesday, October 6, 2020 10:42 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>
> Cc: dev at dpdk.org; akhil.goyal at nxp.com; Coyle, David
> <david.coyle at intel.com>
> Subject: [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session
> 
> When destroying a security session, the AESNI-MB PMD attempted to clear the
> private aesni_mb session object to remove any key material. However, the
> function aesni_mb_pmd_sec_sess_destroy() cleared the security session object
> instead of the private session object.
> 
> This patch fixes this issue by now clearing the private session object.
> 
> Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol")
> 
> Signed-off-by: David Coyle <david.coyle at intel.com>

Patch looks good, but you need to CC stable, as this should be backported since the issue was introduced in the previous release.
So, add Cc: stable at dpdk.org after Fixes: fda... and send a v2.
Apart from that, you can keep my ack:

Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>


More information about the dev mailing list