[dpdk-dev] [PATCH 20/22] event/dlb2: add queue and port release
Eads, Gage
gage.eads at intel.com
Wed Oct 7 23:55:14 CEST 2020
> static void
> +dlb2_eventdev_queue_release(struct rte_eventdev *dev, uint8_t id)
> +{
> + RTE_SET_USED(dev);
> + RTE_SET_USED(id);
> +
> + /* This function intentionally left blank. dlb2 does not support
> + * reconfiguring individual queues or ports -- the entire device
> + * must be reconfigured.
> + */
I think the 2nd sentence in the comment need to be reconsidered (or just
removed). The release callbacks are called (for every port and queue) when
rte_event_dev_configure() is called a 2nd/3rd/etc. time to reconfigure the
device, and the callbacks give the PMD the opportunity clean-up the individual
port/queue. Implementing the logic can be useful for
entire-device-reconfiguration.
> +}
> +
> +static void
> +dlb2_eventdev_port_release(void *port)
> +{
> + RTE_SET_USED(port);
> +
> + /* This function intentionally left blank. dlb2 does not support
> + * reconfiguring individual queues or ports -- the entire device
> + * must be reconfigured.
> + */
This might be the appropriate place to free each port's memzone (see my
comments in patch 11).
Thanks,
Gage
More information about the dev
mailing list